call(back)

What Makes a Good Code Review?

What makes a good code review?

Answer out loud in under a minute, from your own work first.

Hints

Hint 1

Answer from your own reviews first, then generalize: what do you check, and in what order?

Solution

Show the approach

Answer

Correctness and edge cases first, then readability and naming, tests, and consistency with the codebase. Small diffs, specific comments, and a clear split between blocking issues and preferences.

Asked at